Fixes the behavior of throwing table not found error during CREATE OR REPLACE Delta uniform table #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzlfred
changed the title
harperjiang
approved these changes
Nov 5, 2024
lzlfred
force-pushed
the
lzlfred/fix-replace
branch
from
fb5acd0
to
77f186c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
If its the first time we are creating the delta uniform table and the table does not exist yet, we want to synchronously trigger the uniform conversion after the CreateDeltaTableCommand have created the table in the catalog; The existing code only checked for isReplace, but it missed to check if the table existed in the catalog or not. Adding this check fixes the behavior of throwing table not found error during CREATE OR REPLACE Delta uniform table for the very first time.
How was this patch tested?
manual test.